Repository navigation
chore(protocol): sync diagnostic API read contract - #91
Conversation
Signed-off-by: Fredrik Ahlgren <fredrik@sourceful-labs.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d4e11a7d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - { msg: logs.get, scope: ftw.logs.read, desc: A log excerpt the box redacts } | ||
| - { msg: config.get, scope: ftw.config.read, desc: A configuration section the box redacts } | ||
| - { msg: diag.run, scope: ftw.diag.run, desc: A check that changes nothing } | ||
| - { msg: api.read, const: MsgAPIRead, scope: ftw.diag.run, desc: Read the full technical diagnostic API } |
There was a problem hiding this comment.
When an agent or support offer requests ftw.diag.run, OfferFlowView displays AccessWords.scope, whose override in AccessWords.swift:96 still says only “Run checks that change nothing.” This new operation lets the same grant read the full technical diagnostic API, so owners can approve materially broader access without being told what it permits; update the localized scope wording alongside this contract change.
Useful? React with 👍 / 👎.
| - { msg: logs.get, scope: ftw.logs.read, desc: A log excerpt the box redacts } | ||
| - { msg: config.get, scope: ftw.config.read, desc: A configuration section the box redacts } | ||
| - { msg: diag.run, scope: ftw.diag.run, desc: A check that changes nothing } | ||
| - { msg: api.read, const: MsgAPIRead, scope: ftw.diag.run, desc: Read the full technical diagnostic API } |
There was a problem hiding this comment.
When the box records this newly recognized read as what: api.read, AccessWords.what cannot find it in auditWords (AccessWords.swift:345-366) and falls back to displaying the raw protocol token api.read in the owner’s activity log, including in Swedish. Add the corresponding English audit phrase and translation so diagnostic API access remains intelligible and localized like every other registered read.
Useful? React with 👍 / 👎.
1 participant
Copy the canonical
api.readregistry operation and full diagnostic-grant description from webapp #98. Core #1723 and Cloud #35 use it for full technical troubleshooting through MCP.All three registry copies match byte for byte. Swift and shared JVM tests pass; the Swift contract suite also checks the final wording. No native UI or session behavior changes.