Skip to content

chore(ci): replace SourceKnight with setup-sp - #22

Merged
Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight
Aug 18, 2026
Merged

Rushaway merged 1 commit into
masterfrom
chore/drop-sourceknight

Conversation

@Rushaway

Copy link
Copy Markdown
Member

Summary

  • Replace the SourceKnight-based build (maxime1907/action-sourceknight) with a native GitHub Actions workflow.
  • Compile with spcomp via rumblefrog/setup-sp@v1.3.1, pinned to SourceMod 1.12.x.
  • Fetch the VIP_Core dependency directly with git clone and copy its includes into addons/sourcemod/scripting/include.
  • Keep the existing tag/release behavior: auto-tag latest and publish a release archive on pushes to master/main, or on tag pushes.
  • Remove sourceknight.yaml, drop the .sourceknight entry from .gitignore, and update .github/copilot-instructions.md to describe the new build process.

Test plan

  • CI workflow run on this PR compiles VIP_Tag.sp successfully via GitHub Actions.

Copilot AI lite review requested due to automatic review settings August 17, 2026 18:57

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Rushaway
Rushaway force-pushed the chore/drop-sourceknight branch from a7c0681 to 5da5406 Compare August 18, 2026 08:04
@Rushaway
Rushaway merged commit 56c3d34 into master Aug 18, 2026
6 checks passed
@Rushaway
Rushaway deleted the chore/drop-sourceknight branch August 18, 2026 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants