Skip to content

Potential fixes for 2 code quality findings #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aledbf merged 2 commits into from
Aug 25, 2026
Merged

Potential fixes for 2 code quality findings #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9b63e3
Apply suggested fix to internal/lifecycle/initialize_test.go from Cop…
aledbf Aug 25, 2026
fad6ae8
Apply suggested fix to internal/lifecycle/initialize_test.go from Cop…
aledbf Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal/lifecycle/initialize_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,10 @@ func TestRunInitializeCommand(t *testing.T) {
{"string form with substitution", cmdFromJSON(t, `"true # ${localWorkspaceFolder}"`), false},
{"string form non-zero exit", cmdFromJSON(t, `"false"`), true},
{"array form", cmdFromJSON(t, `["true"]`), false},
{"array form non-zero exit", cmdFromJSON(t, `["false"]`), true},
{"array form with substitution", cmdFromJSON(t, `["true", "${localWorkspaceFolder}"]`), false},
{"object form parallel", cmdFromJSON(t, `{"a": "true", "b": "true"}`), false},
{"object form parallel with failure", cmdFromJSON(t, `{"a": "true", "b": "false"}`), true},
}

for _, tt := range tests {
Expand Down
Loading