Repository navigation
Publish section-marker-rev@2.0.2 - #63
Golevka2001 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the section-marker-rev@2.0.2 publish entry in this run.
- Vault version entry — adds
2.0.2artifact URL, checksum, and timestamp tovault/section-marker-rev.json.
muse-spark-1.3-contributor (free via Pullfrog for OSS) | 𝕏
There was a problem hiding this comment.
Verdict: no concerns
Provenance: verified at Golevka2001/section-marker-rev@bc6fc560aa886d9e2299fceab5a76ab2777ee0b2 (built by spicetify/actions build-module, run). Reviewed the source at that commit: index.ts, mod.ts, app.ts, analysis-loader.ts, analysis-cache.ts, interface.ts, logic.ts, dom-watcher.ts, metadata.json, package.json, bun.lock.
Findings: none.
- Network: no
fetch/XHR/WebSocket/sendBeacon/remote URLs. The only data call isSpicetify.getAudioData(uri)(analysis-loader.ts), the client's local audio-analysis entry point, disclosed inmetadata.jsonstdlibBoundary.exceptions. No hosts contacted, nothing to explain in the description. - Remote/dynamic code: none. No
eval/new Function/remoteimport()/script injection/innerHTML. DOM is built withcreateElement+classList/dataset/style.setProperty; the pinned<style>copies the module's own rules filtered by signature (interface.ts), not remote content. - Credentials/sessions: no tokens, cookies,
AuthorizationAPI, daemon token,127.0.0.1:7967,CORSProxy, orlocalStoragewrites.player.origin.getState()andSpicetify.Queueare read locally for the current/next track URI (app.ts); nothing leaves the machine. - Loader hang (delta vs 2.0.0): fixed, not introduced. The default export is sync and
main()runs fire-and-forget (mod.ts),waitForElmresolvesnullafter 5s (dom-watcher.ts), and analysis requests time out after 8s (analysis-cache.ts). - Supply chain:
package.jsonhas dev-only deps (kit, types, oxfmt/oxlint, typescript), no install scripts;bun.lockuses integrity hashes with no off-registryresolvedURLs.
Not reviewed: the built zip bytes (attestation + CI checksum trusted instead); test stubs beyond noting their dynamic import() is test-harness-only.
muse-spark-1.3-contributor (free via Pullfrog for OSS) | 𝕏
There was a problem hiding this comment.
Verdict: no concerns
Provenance: verified at Golevka2001/section-marker-rev@bc6fc56 (built by spicetify/actions build-module, run 38505495417). Reviewed the source at that commit: index.ts, mod.ts, app.ts, interface.ts, analysis-loader.ts, analysis-cache.ts, logic.ts, dom-watcher.ts, metadata.json, package.json, bun.lock, and the release workflow.
Findings: none.
- Network: no
fetch,XMLHttpRequest,WebSocket,EventSource,sendBeacon, or remote URLs. The only data source isSpicetify.getAudioData(uri), the in-client audio-analysis entry point, which is disclosed inmetadata.jsonstdlibBoundary.exceptions. No hosts contacted, nothing leaves the machine. - Remote/dynamic code: none. Only a static local
import("./mod.js"); DOM is built withcreateElement/classList/style.setProperty/dataset, andtextContentis set only from the module's own stylesheet rules. Noeval,new Function, stringsetTimeout, remoteimport(), injected<script>,innerHTML, oratob/fromCharCode. - Credentials/sessions: none touched. Reads player state and queue URIs for display/preload only; no tokens, cookies, daemon token,
127.0.0.1:7967,CORSProxy, orlocalStoragewrites. - Concealment: none. Plain readable TypeScript matching the description (section markers on the playbar).
- Supply chain:
package.jsonhas dev-only tooling deps plusstdlib ^1.10.4, no install scripts;bun.lockcarries integrity hashes with no off-registryresolvedURLs; the release workflow uses the standardspicetify/actionsbuild + publish path. - Loader hang: the default export in
mod.tsis synchronous (async startup runs detached viavoid main().then(...)), the client-readiness poll is off the loader promise and abort-aware,waitForElmresolvesnullafter a 5s timeout, and analysis requests are bounded by an 8s timeout with a 10s retry gap. The 2.0.2 changelog entries describe exactly these hang fixes, consistent with the code.
Not reviewed: the built zip bytes themselves (trusted via attestation + the validator's re-hash rather than re-downloaded), and no code was run, installed, or built — read-only review.
muse-spark-1.3-contributor (free via Pullfrog for OSS) | 𝕏
fbd4a51 to
4dc42ca
Compare
There was a problem hiding this comment.
Verdict: no concerns
Provenance: verified at Golevka2001/section-marker-rev@bc6fc560aa886d9e2299fceab5a76ab2777ee0b2 (built by spicetify/actions build-module, run). Reviewed the source, metadata.json, package.json, and bun.lock at that commit.
Findings: none. Checked the full source at the attested commit:
- Network: no
fetch,XHR,WebSocket,EventSource,sendBeacon, or remote URLs. The only data call is the client's built-inSpicetify.getAudioData(uri)(client-local audio analysis, matches the "song's highlighted sections" description). Queue peek atapp.tsis disclosed inmetadata.jsonstdlibBoundary.exceptions. - Remote/dynamic code: only a local relative
import("./mod.js"); noeval,new Function, remoteimport(), orinnerHTML. Created<style>/<div>elements use the module's own stylesheet rules (filtered bysection-markersignature) and local DOM only. - Credentials/sessions: reads only the current track URI and queue URIs; no tokens, cookies, or off-machine sends.
- Spicetify internals: no daemon token, no
127.0.0.1:7967, noCORSProxy/CosmosAsync, nolocalStoragewrites. - Concealment: plain readable TypeScript; no minification,
atob/fromCharCode, or encoded blobs. - Supply chain:
devDependenciesonly (@spicetify/kit,@types/*,oxfmt,oxlint,typescript), no install scripts, no runtime deps;bun.lockcarries integrity hashes with no off-registryresolvedURLs; release workflow delegates tospicetify/actionsbuild/publish with nothing fetching code. - Loader hang: fixed, not introduced, in this version. The default export is now synchronous and returns teardown immediately, with startup detached via
void main(...); the client-ready wait is abortable and off the loader promise,waitForElmresolvesnullafter 5s, and analysis requests are bounded by an 8s timeout. - Diff vs 2.0.1: the changes are the hang fixes, bounded waits/retries, and teardown handling; no new network, credential, or persistence surface.
Did not review: the built zip bytes (source at the attested commit reviewed instead; checksum and zip-entry safety left to the CI validator). Nothing was run, installed, or built.
muse-spark-1.3-contributor (free via Pullfrog for OSS) | 𝕏

Submitted by the publish action from Golevka2001/section-marker-rev. The artifact is downloaded and re-hashed by the validator.