reimplement OpenSHC::Text::TextEditorState - #224
Draft
TheRedDaemon wants to merge 28 commits into
Draft
Conversation
TheRedDaemon
force-pushed
the
reimpl/text-editor-state
branch
from
September 6, 2026 17:45
24fb253 to
1390bbc
Compare
gynt
reviewed
Sep 13, 2026
| _fwprintf; | ||
|
|
||
| MACRO_FUNCTION_RESOLVER( | ||
| long(__cdecl*)(wchar_t const*), REIMPLEMENTED_CRT, Address::SHC_3BB0A8C1_0x00580BFA, &OpenSHC::OS::__wtol) |
Contributor
There was a problem hiding this comment.
0x00580c0b is the thunk containing the jmp, so that one is actually the public-facing one, right? Or do you thing it should be 0x00580BFA
TheRedDaemon
force-pushed
the
reimpl/text-editor-state
branch
from
September 13, 2026 20:56
6e11be9 to
276c1d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed it while reimplementing
drawBorderStyle0x20:dialogContentWidthanddialogContentHeightare likely swapped.And if not them, then
dialogWidthanddialogHeight.It should be fixed within this PR, I am just unsure whether or not it should be done now or at the end.
intArray1is seems to be an array ofwchar_t*.If I forget it, please remember me.
Many of the shorter functions share knowledge with some bigger and certain Menu functions.
These might partially all have been one giant file. Once the day comes, we likely need to use the GL method again. It is important to be careful then, so that we do not end up giving files knowledge of each other that they should not have.
There seem to be
ints/shorts/wchar_tsthat represent certain help text tokens. These could use an enum.The L-strings need to be replaced with a string file reference.
Document the hlp-file structure a bit.