Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JetStreamContext::createStreamandupdateStreamwith a clear\InvalidArgumentExceptionnaming the offendingvalue, instead of letting the request time out waiting for a reply that will
never come.
.,*,>,/,\, or control characters.createOrUpdateStreampicks up the guard transitively.Why
A bad character in the stream name produced
Sofascore\Nats\TimeoutException: Subscription nextMessage timed out, whichgave no signal that the caller's input was the problem. Fixing this at the
boundary turns a hard-to-diagnose timeout into an actionable error.
Fixes #81
Test plan
vendor/bin/phpunit --testsuite=unitpasses (includes the newJetStreamContextStreamNameValidationTestcovering each forbidden charclass plus empty input and 6 valid shapes).
vendor/bin/phpstan analyse --no-progressclean.vendor/bin/php-cs-fixer fix --dry-run --diffclean.createStream(new StreamConfig(name: 'bad.name'))nowthrows
\InvalidArgumentExceptionimmediately instead of timing out.