Repository navigation
fix: remove JetStream async publish surface - #69
Merged
Merged
Conversation
There was a problem hiding this comment.
No findings from me with the async-publish API removal treated as intentional.
Verified locally with:
vendor/bin/phpunit tests/Integration/JetStream/PublishTest.phpvendor/bin/phpunit tests/Integration/JetStream/PublishExtendedTest.phpvendor/bin/phpunit tests/Integration/JetStreamvendor/bin/phpunit tests/Unit/JetStream/JetStreamOptionsTest.phpvendor/bin/phpunit tests/Unit/JetStream/Consumer/PushConsumerTest.phpvendor/bin/phpstan analyse src --no-progress
I also checked for leftover references to the removed async publish surface and did not find any.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The current async publish path is a thin convenience wrapper around per-publish reply subscriptions and pending-future bookkeeping. It does not provide strong enough runtime semantics to justify a public async API.
Breaking change
JetStreamContext::publishAsync()JetStreamContext::publishAsyncMessage()JetStreamContext::publishAsyncPending()JetStreamContext::publishAsyncComplete()JetStreamContext::cleanupPublisher()JetStreamOptions::$publishAsyncMaxPendingJetStreamOptions::$publishAsyncErrHandlerPubAckFutureValidation
./vendor/bin/phpunit tests/Integration/JetStream/PublishTest.php tests/Integration/JetStream/PublishExtendedTest.php --testdox./vendor/bin/phpunit tests/Unit/JetStream --testdox./vendor/bin/phpstan analyse --no-progressCloses #38