Harden SSH command execution and temporary files - #3
Open
santiagocasas wants to merge 1 commit into
Open
santiagocasas wants to merge 1 commit into
santiagocasas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
This tightens up the places where the plugin builds SSH commands and temporary files.
The old code passed interpolated strings to a local shell. That meant a specially crafted
host or command could be interpreted locally instead of being handed to SSH as plain data.
The files used to disable local tools also had predictable names under
/tmp.This PR:
execFileSync()with argument arrays for SSH connection management;0600permissions.Commands containing pipes, redirects,
&&, or similar shell syntax still work on theremote host. They are no longer evaluated by the local shell while the SSH command is
being assembled.
I kept this PR limited to the command-execution and temporary-file hardening. Connection
health checks, fail-closed behavior, and the launcher are separate follow-up PRs.
Checks
git diff --cached --check.AI assistance
The code and this PR description were generated with help from GPT-5.6-Sol.