Skip to content

DecisionTreeClassifier doesn't split node with min_samples_split examples #463

Description

@slievens

DecisionTreeClassifier doesn't split nodes with exactly min_samples_split examples due to this line

        if n <= self.parameters().min_samples_split {
            return false;
        }

This should be

        if n < self.parameters().min_samples_split {
            return false;
        }

as it is in BaseTreeRegressor.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions