Repository navigation
Improve prov - #161
Merged
Merged
Improve prov#161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the SKALE node provisioning and deployment system, focusing on enhanced preflight validation, better documentation, new utility scripts, and inventory template updates. The most significant changes are the addition of a comprehensive preflight check playbook, new Python utility scripts for source builds and passive node whitelisting, and updates to inventory templates to improve clarity and correctness.
Preflight validation and pipeline robustness:
preflight.yamlplaybook that validates inventory variables before running pipelines, ensuring missing or incorrect values are caught early and providing stage-specific checks for contracts, nodes, SGX, chains, and Fair deployments. Pipelines and node registration playbooks now import this preflight check at the start. [1] [2] [3] [4] [5] [6]New utility scripts:
compose_from_source.py, a Python script that rewrites adocker-compose.ymlto build SKALE containers from local source repositories, supporting more flexible development workflows.whitelist_passive_skale.py, a utility to whitelist passive SKALE node IPs in the SyncManager, including logic to grantSYNC_MANAGER_ROLEif necessary.Documentation improvements:
README.mdwith detailed sections on upgrading OS packages, pipeline usage, passive node whitelisting, and the behavior of playbooks and utility scripts, making setup and maintenance procedures clearer. [1] [2] [3]Inventory template and variable improvements:
docker_lvmpy_stream→docker_lvmpy_version, fixed typo inbase_domain_name), setcleanup_sgxdefault toFalse, and fixed a typo inskale_watchdog_path. [1] [2] [3]Dependency updates and minor fixes:
ruamel.yamltorequirements.txtfor YAML processing in utility scripts.pack_subvolumes.pycleanup and makingCHAIN_TYPEfallback logic more robust increate_chain.py. [1] [2] [3]These changes collectively improve the reliability, maintainability, and developer experience of the SKALE node provisioning system.