Repository navigation
Fix skale node support - #148
Merged
Merged
Conversation
dmytrotkk
requested review from
badrogger and
dmytrotkk
and removed request for
badrogger
November 25, 2025 16:35
dmytrotkk
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to the Ansible configuration and Docker Compose templates for SKALE nodes, focusing on improved container management, better handling of node types, and some restructuring for clarity and maintainability. The most important changes include refactoring Docker Compose templates, updating cleanup and deployment tasks to support both SKALE and FAIR node types, and enhancing playbook logic for conditional execution.
Docker Compose Template Refactoring:
services:andbase:anchor pattern with a newx-sk-baseanchor, and restructured the templates fordocker-compose.yml.j2,docker-compose-fair.yml.j2, anddocker-compose-passive.yml.j2to improve maintainability and clarity. [1] [2] [3] [4] [5] [6]Container Cleanup and Management:
containers.yamlto use a more generic filter for container names and consolidated admin container removal for both SKALE and FAIR node types, removing redundant tasks and improving conditional checks. [1] [2]cli_cleanup.yamlusing the new command prefix logic.Node Type Handling and Conditional Logic:
fair_bootandfairnode types. [1] [2]Anvil Container Management:
Playbook Restructuring:
skale_pipeline.yamland added thecreate_chain.yamlplaybook to the pipeline for better organization and extensibility. [1] [2]