Repository navigation
Fix quoted Chrome host resolver rules - #2572
Merged
Merged
Conversation
Chromedriver starts Chrome without a shell, so the quotes around the --host-resolver-rules value reached Chrome's rule parser. Chrome then dropped the first and last rules. In WebPageReplay mode the port 80 mapping was lost, so plain HTTP requests went to the real internet instead of the replay server; packet captures showed Chrome's clients2.google.com time check leaving the container this way. In default mode the first and last phone-home blocks were lost. A unit test now checks that the arguments contain no quotes. Assisted-by: Claude Opus 5.5 noreply@anthropic.com Change-Id: I474cf27456bd77a86c4434b312bab51cd0915553
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromedriver starts Chrome without a shell, so the quotes around the --host-resolver-rules value reached Chrome's rule parser. Chrome then dropped the first and last rules. In WebPageReplay mode the port 80 mapping was lost, so plain HTTP requests went to the real internet instead of the replay server; packet captures showed Chrome's clients2.google.com time check leaving the container this way. In default mode the first and last phone-home blocks were lost.
A unit test now checks that the arguments contain no quotes.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com
Change-Id: I474cf27456bd77a86c4434b312bab51cd0915553