Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #369.
_chunk_markdownreturned a heading-less file as one chunk and skippedMAX_CHUNK_CHARS. A file with headings could still exceed the cap when a single paragraph was longer than the limit, because the splitter only cuts on blank lines.#heading is now one section and goes through the same size pass as headed files.MAX_CHUNK_CHARSafter the paragraph split is cut on a newline or space, or mid-token when there is no whitespace.How Has This Been Tested?
python3 -m pytest tests/test_rag_chunking.pyMAX_CHUNK_CHARSis split, and every chunk stays within the cap.Top,Top > Nested,Second) are unchanged.Checklist