fix(desktop-browser): add recoverable page failure states - #7142
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR adds recoverable browser failure states while preserving navigation, focus, and tab metadata.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/desktop/src/main/browser-agent/session.ts | Adds per-tab recovery state and recovery-aware navigation helpers; the previous synthetic Forward issue is addressed by consuming preservation on every main-frame navigation start. |
| apps/desktop/src/main/browser-agent/driver.ts | Publishes main-frame load failures and routes both panel and agent navigation through the session recovery path. |
| apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/browser-session/browser-page-issue.tsx | Adds the documented, accessible recovery component and sanitized failure-specific copy. |
| apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/components/browser-session/browser-session.tsx | Integrates recovery rendering, focus handoff, panel visibility, and Chromium-style omnibox pointer selection. |
| apps/sim/stores/browser-session/store.ts | Propagates recoverable page issue state through the browser session store. |
| packages/browser-protocol/src/index.ts | Extends shared page and tab state contracts with recoverable browser issue metadata. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
Failure[Main-frame failure or renderer issue] --> Session[Record tab page issue]
Session --> State[Publish page and tab state]
State --> Recovery[Render recovery view]
Recovery --> Reload[Reload or retry failed URL]
Recovery --> Back[Back dismisses failed entry]
Back --> Synthetic[Preserve failed URL as synthetic Forward]
Synthetic --> Forward[Forward retries failed URL]
Reload --> Navigation[Chromium navigation]
Forward --> Navigation
Navigation --> Clear[Clear transient recovery state]
Reviews (3): Last reviewed commit: "fix(desktop-browser): expire stale recov..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
waleedlatif1
force-pushed
the
codex/desktop-browser-errors
branch
from
August 27, 2026 00:47
5d5dbd2 to
fd89cb3
Compare
Collaborator
Author
waleedlatif1
force-pushed
the
codex/desktop-browser-errors
branch
from
August 27, 2026 00:57
fd89cb3 to
2eb0950
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run lintbun run apps/sim/scripts/check-block-registry.ts origin/stagingbun run check:auditsbun run --cwd apps/desktop test(1,190 tests)Checklist