fix(landing): harden cross-browser compatibility - #7139
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Greptile SummaryThe PR adds feature-gated color fallbacks for older browser engines, narrows animated properties, and provides an inert fallback for Firefox 111.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported retired token namespace has been removed consistently from the fallback definitions and both loader consumers.
|
| Filename | Overview |
|---|---|
| apps/sim/app/(landing)/components/shared/color-mix-fallbacks/color-mix-fallbacks.module.css | Defines baseline colors for legacy engines and restores modern color-mix values behind feature detection; the loader property rename is complete and consistently scoped. |
| apps/sim/app/(landing)/components/hero/components/hero-visual/hero-visual.tsx | Applies the renamed loader compatibility property from an ancestor of ThinkingLoader, preserving the expected inheritance chain. |
| apps/sim/app/(landing)/components/navbar/components/logo-mark/logo-mark.tsx | Uses the component-scoped loader property consistently and retains the fallback and modern loader color behavior. |
| apps/sim/app/(landing)/demo/components/legacy-inert-fallback.ts | Implements legacy interaction blocking with restoration of prior ARIA, pointer-event, and tabindex state. |
| apps/sim/app/(landing)/demo/components/demo-booking/demo-booking.tsx | Applies the legacy inert fallback only when native inert support is unavailable. |
| apps/sim/app/(landing)/demo/components/legacy-inert-fallback.test.ts | Covers interaction suppression, exact state restoration, and focus removal for the legacy fallback. |
Reviews (3): Last reviewed commit: "fix(landing): blur legacy inert focus" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 22 files
Confidence score: 4/5
- In
apps/sim/app/(landing)/demo/components/demo-booking/demo-booking.tsx, Firefox 111 can leave the Continue button focused inside a panel that becomesaria-hiddenand removed from the tab order, creating an accessibility and keyboard-navigation issue; move focus to the scheduler or blur the active form before hiding it.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/app/(landing)/demo/components/demo-booking/demo-booking.tsx">
<violation number="1" location="apps/sim/app/(landing)/demo/components/demo-booking/demo-booking.tsx:40">
P2: When the form advances in Firefox 111, the clicked Continue button remains focused inside the panel this fallback makes `aria-hidden` and removes from the tab order. Move focus to the scheduler or blur the active form control before applying the fallback.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Collaborator
Author
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested with lint, 33 repository audits, type-check, focused Vitest coverage, production build, and Chromium/Firefox/WebKit landing smoke checks.
Checklist