improvement(canvas): improve code tooltip readability - #7138
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThe PR improves canvas code-preview readability while keeping tooltips within the viewport.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or non-blocking defects identified. The new CSS-width value is hardcoded and viewport-clamped, numeric callers retain their previous behavior, and the code viewer’s wrapping and gutter layout support the intended vertically scrollable preview.
|
| Filename | Overview |
|---|---|
| packages/emcn/src/components/popover/popover.tsx | Safely broadens the maximum-width API to support trusted CSS length expressions while retaining existing numeric behavior. |
| packages/workflow-renderer/src/lib/code-hover-card.tsx | Adds a viewport-clamped wider tooltip and configures the code viewer for wrapped text, line numbers, and vertical scrolling. |
| packages/workflow-renderer/src/lib/overflow-span-mount.test.tsx | Updates focused assertions to reflect the revised tooltip width and wrapped gutter presentation. |
Reviews (1): Last reviewed commit: "improvement(canvas): improve code toolti..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
bun run lintbun run check:auditsbun run testandbun run type-checkin the affected packagesChecklist