feat(workflows): expose authenticated run subjects - #7088
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThe PR preserves authenticated workflow subjects across chat authentication, execution boundaries, and nested runs, then exposes normalized subject metadata to Start blocks.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| apps/sim/app/api/chat/utils.test.ts | Replaces the previously flagged ad-hoc cookie fixtures with typed NextRequest instances and real Cookie headers, resolving the prior review issue. |
| apps/sim/lib/core/security/deployment.ts | Extends signed deployment-auth tokens with normalized authenticated-email claims while safely rejecting identity-free legacy email tokens. |
| apps/sim/lib/workflows/executor/start-run-identity.ts | Normalizes supported principal subjects into the optional Start-block run metadata contract. |
| apps/sim/executor/handlers/workflow/workflow-handler.ts | Preserves the original execution principal while updating nested-workflow delegation scope. |
| packages/auth/src/principal.ts | Adds authenticated-email subjects and centralized subject resolution for supported workflow principals. |
Sequence Diagram
sequenceDiagram
participant Caller
participant Auth as Deployment Auth
participant Runner as Workflow Runner
participant Queue as Queue/Snapshot
participant Child as Nested Workflow
participant Start as Start Block
Caller->>Auth: Authenticate request
Auth-->>Runner: Signed principal and subject
Runner->>Queue: Serialize execution principal
Queue-->>Runner: Restore execution principal
Runner->>Child: Preserve caller principal and workflow scope
Runner->>Start: Resolve normalized run subject
Start-->>Caller: Optional trusted run metadata
Reviews (5): Last reviewed commit: "fix(workflows): remove duplicate run ema..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 90 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
b3ca91c to
266f4fc
Compare
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
531cb5b to
e5e3a4a
Compare
|
@cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings. |
e5e3a4a to
68572ce
Compare
Summary
Type of Change
Testing
Checklist