Repository navigation
Conversation
Muguett-DBY
left a comment
There was a problem hiding this comment.
Thanks for adding the Bash 3 fallback. One version boundary to consider: Bash 4.0–4.3 also lack complete -o nosort; GNU's Bash 4.4 release notes list that option as new in 4.4. The >= 4 check still selects nosort on those versions. That limitation already exists on main; it isn't introduced by this PR. Could the condition check for 4.4 or newer instead?
There's also a misleading warning on the new Bash 3 path: with Click 8.5, super().source() calls Click's version check, which writes “Shell completion is not supported for Bash versions older than 4.4” even when this fallback would work.
I exercised the exact PR completion class with Click 8.5 and Bash 5.3. The older versions were simulated against the documented option boundary; I didn't run actual Bash 3 or 4. OpenAI Codex (GPT-6) assisted with the review and checks.
Summary
complete -o nosortoption on older Bash versions.-o nosortfor Bash 4 and newer.Testing
uv run pytest— 1275 passed, 1 skipped, 6 xfailed, 26 xpassed.uv run ruff check llm/cli.py tests/test_cli_options.py— passed.git diff --check— passed.The generated completion script was checked locally; execution on macOS Bash 3.2 has not been verified directly.