Add download for a device - #33
Open
siliconwitch wants to merge 3 commits into
Open
siliconwitch wants to merge 3 commits into
siliconwitch wants to merge 3 commits into
Conversation
Download fetches the bundle the server holds for a device and writes it into a new or empty directory. It never reads the device.
Download accepted only an empty or new directory. It now writes into any directory, lists the bundle files that already exist there, and asks once before replacing them.
The fixture combined each call with its error test, which the coding rules forbid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
download <imei> <path>fetches the bundle the server holds for a device throughGET /devices/{imei}/filesand writes it into a new or empty directory. It never reads the device. A fleet id is refused, because a fleet upload is a shortcut that pushes one bundle to every device and there is nothing fleet-level to return.Every bundle path is checked before anything is written, so a bad response cannot escape the target directory. The response is decoded under the existing 32 MiB cap.
CGO_ENABLED=0 go build,go vetandgo test ./...pass,gofmt -l .prints nothing andgo mod tidychanges nothing. No third-party dependency and no version change. Ship after the server route deploys.