Skip to content

chore(deps): upgrade jsdom, CLI widths and Icons hotkeys - #887

Merged
anandpant merged 2 commits into
mainfrom
chore/upgrade-majors
Nov 19, 2026
Merged

anandpant merged 2 commits into
mainfrom
chore/upgrade-majors

Conversation

@anandpant

@anandpant anandpant commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

Changes and compatibility

  • jsdom 30.1.3 → 31.0.1 (31.0.0 notes, 31.0.1 notes). The optional native canvas backend changes from canvas to @napi-rs/canvas, CSS parsing/computed values and selector behavior change, and blocking scripts can leave a document partially parsed until readiness. Our Vitest environments don't opt into execution of blocking scripts or the native canvas backend; the SVG suites use their existing canvas shim. The CSS, selector, and focus changes are exercised by the DOM suites. The pinned Node 26.13.0 satisfies jsdom's engine range.
  • string-width 8.3.0 → 9.0.0 (release notes). The Node floor rises to 22, below the packed CLI's existing 24.13 floor. The CLI uses the same default export for display-cell counts in help and list. Unicode cluster widths improve for emoji presentation, keycaps, flags, skin tones, Indic/Hangul and other scripts. wrap-ansi still resolves 8.3.0 internally; the shipped notices name both versions and the installed Chalk 6.0.1. list now truncates at grapheme boundaries so it drops a whole overflowing Indic conjunct instead of printing part of it.
  • React Hotkeys 0.19.0 → 0.27.0 (React changelog, core changelog). Icons declares concrete shortcuts and omits target for document bindings; search-field bindings use a mounted ref and now run after React handlers. Escape yields to the active dialog or menu before the grid sees it. No use of the removed key sets/types, the recorder (key naming and result reasons changed), held-key helpers (non-letter casing changed), or Cmd+Shift punctuation fallbacks. The command palette uses useFormatForDisplay in place of the deprecated component-level formatter.

Fresh recursive inventory confirmed these versions. No out-of-scope updates or changes to dependency policies. The CLI dependency-only manifest change starts release.yml on merge; the existing cli-v0.42.4 release tag makes the guard skip publishing. No CLI version bump or changeset. The shared lockfile can trigger all four Worker deployments on merge.

Local proof

  • pnpm ci:local --no-signoff, including the affected jsdom suites and all builds.
  • Icons integration tests: select filtered results via Mod+A, and Mod+K/first Escape on the command palette without clearing the filter.
  • pnpm nx run sketchi-cli:smoke; built CLI in a 36-column PTY with ANSI-colored help and a Unicode title, emoji, and Indic conjunct truncation and alignment check in list at 64 columns. The existing CLI command-flow test covers the conjunct regression.
  • pnpm nx run drawing:corpus-renderer for the jsdom-based SVG renderer.

No browser automation, hosted preview, release dispatch, or deploy was run.

@socket-security

socket-security Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedjsdom@​30.1.3 ⏵ 31.0.198 +1100100 +19880 -19
Addedstring-width@​9.0.01001008985100
Updated@​tanstack/​react-hotkeys@​0.19.0 ⏵ 0.27.0100 +1100100 +198 +1100

View full report

@anandpant
anandpant force-pushed the chore/upgrade-majors branch from c4f5d11 to 9d19074 Compare November 19, 2026 06:56
@anandpant
anandpant merged commit bd83003 into main Nov 19, 2026
8 checks passed
@anandpant
anandpant deleted the chore/upgrade-majors branch November 19, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant