Repository navigation
chore(deps): upgrade jsdom, CLI widths and Icons hotkeys - #887
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
anandpant
force-pushed
the
chore/upgrade-majors
branch
from
November 19, 2026 06:56
c4f5d11 to
9d19074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and compatibility
canvasto@napi-rs/canvas, CSS parsing/computed values and selector behavior change, and blocking scripts can leave a document partially parsed until readiness. Our Vitest environments don't opt into execution of blocking scripts or the native canvas backend; the SVG suites use their existing canvas shim. The CSS, selector, and focus changes are exercised by the DOM suites. The pinned Node 26.13.0 satisfies jsdom's engine range.string-width8.3.0 → 9.0.0 (release notes). The Node floor rises to 22, below the packed CLI's existing 24.13 floor. The CLI uses the same default export for display-cell counts in help andlist. Unicode cluster widths improve for emoji presentation, keycaps, flags, skin tones, Indic/Hangul and other scripts.wrap-ansistill resolves 8.3.0 internally; the shipped notices name both versions and the installed Chalk 6.0.1.listnow truncates at grapheme boundaries so it drops a whole overflowing Indic conjunct instead of printing part of it.targetfor document bindings; search-field bindings use a mounted ref and now run after React handlers. Escape yields to the active dialog or menu before the grid sees it. No use of the removed key sets/types, the recorder (key naming and result reasons changed), held-key helpers (non-letter casing changed), or Cmd+Shift punctuation fallbacks. The command palette usesuseFormatForDisplayin place of the deprecated component-level formatter.Fresh recursive inventory confirmed these versions. No out-of-scope updates or changes to dependency policies. The CLI dependency-only manifest change starts
release.ymlon merge; the existingcli-v0.42.4release tag makes the guard skip publishing. No CLI version bump or changeset. The shared lockfile can trigger all four Worker deployments on merge.Local proof
pnpm ci:local --no-signoff, including the affected jsdom suites and all builds.pnpm nx run sketchi-cli:smoke; built CLI in a 36-column PTY with ANSI-colored help and a Unicode title, emoji, and Indic conjunct truncation and alignment check inlistat 64 columns. The existing CLI command-flow test covers the conjunct regression.pnpm nx run drawing:corpus-rendererfor the jsdom-based SVG renderer.No browser automation, hosted preview, release dispatch, or deploy was run.