Repository navigation
Conversation
Expose generic seal_input with a compatible seal_join_input spelling. Admit complete direct and narrowly filtered standalone readers without a JOIN prerequisite, preserving mutation freeze, output floors and typed errors. Refs #1372.
Pin and audit originating intern provenance for standalone cold projections. Preserve declared STRING input types and fixed builtin MAP result schemas so ordinary JOIN pipelines retain their key metadata. Cover public consumers, malformed bytecode, ownership, failures and resident memory floors. Refs #1372
justinjoy
force-pushed
the
codex/1372-cold-join-group
branch
from
October 30, 2026 06:31
61b2d1a to
d9e3816
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sealed inputs previously required numeric lanes and a narrow JOIN position. This group extends
wirelog_session_seal_inputto standalone direct/filtered projections, multiple independently sealed inputs, and bounded JOIN consumers in either position, including both-cold, self-JOIN and chains through resident intermediates.The added reference-consumer commits support STRING keys/payloads and scalar child fields of declared flat INLINE compounds. Plans own declaration metadata and original-use provenance; ordinary source initialization establishes the real layout before capture. Sealing and reading validate that layout and originating intern identity, retain reference/functor ownership, and produce scalarized results. Unsupported layouts fail before source retirement. Truthful STRING typing also preserves builtin interpreter result schemas.
This PR keeps the work in separate commits for projections, multiple bindings, numeric JOIN directions, STRING projections, STRING JOINs, declared INLINE initialization and INLINE cold consumers. Follow-up test commits strengthen formatter stability and output-layout assertions. The nine feature/test commits are rebased onto main
3d2dd8f0, retaining main’s UNION/frontier, inherited JOIN_BATCH environment tests and CI fixes. Already squash-merged #2289 commits are excluded from this series.Validation on the exact rebased tree: production broad suite 476 passed, 14 skipped, 0 failed; tidy 4/4; rebuilt ASan/UBSan 17/17 and pthread TSan 17/17 affected targets, including all three inherited JOIN_BATCH environment variants. TSan used the documented
--timeout-multiplier 4from the outset. State/thread attribution, formatting and strict production-profile checks passed. Three overlap resolutions retain every feature test, initialize the inherited environment before any fixture, and combine the generic/compatibility sealing contract with the creation-time knob restriction. Tests cover exact typed results, both sealing orders and JOIN directions, self/chained consumers, malformed provenance, independent reference lifetime, capture/read/output failures and retry, and fixed-budget source reclamation. Hosted native-platform results are tracked by this PR's checks.The supported path remains serial, immutable and nonrecursive, with a single matching INT64 or STRING equality key and the documented restricted projection/filter forms. Intern/declaration metadata, outputs and intermediates remain resident. Whole compounds, SIDE/nested layouts and mutable/differential/control/worker consumers remain follow-up work.
Refs #1372; this group does not close it.