Warn about stale SAC file when channel has no data - #154
Merged
Merged
Conversation
GeorgeS311578
force-pushed
the
fix/stale-file-warning
branch
from
September 24, 2026 05:57
9ea6238 to
93de082
Compare
seisman
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #152 (Case B, as discussed).
When win2sac_32 reports no data for a channel but a file with the
output name already exists on disk, log a warning that it may be stale.
FileNotFoundError keeps propagating untouched, as agreed.
Regression tests use a fake Popen, so no binary, account, or network
is needed: 2 passed.