Use cipher-workaround session for get_station_list - #153
Closed
GeorgeS311578 wants to merge 3 commits into
Closed
GeorgeS311578 wants to merge 3 commits into
GeorgeS311578 wants to merge 3 commits into
Conversation
Owner
|
I'm not fully understand the issue, although the It seems the CI runs passed on Linux for Python 3.10 and 3.14, and on macOS for Python 3.14, but fails on macOS with Python 3.10. Perhaps the easiest solution is bumping the minimum required Python version to 3.11 or later? |
Owner
|
The CI passes on Linux/macOS with Python 3.11. In PR #155, I've bumped the minimum required version to Python 3.11, so the workaround in this PR is no longer needed. |
Contributor
Author
|
Makes sense — if 3.10 is dropped, the workaround is unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_station_list fetched _STATION_INFO with a bare requests.get, so it
crashed with SSLError: DH_KEY_TOO_SMALL on modern OpenSSL (e.g. macOS
runners — see the red Tests #338 log on main).
It now reuses the logged-in session, which already mounts
AddedCipherAdapter, or a throwaway session with the same workaround
when used without login.
Verified live without an account: get_station_list("0101") returns
797 stations.