Repository navigation
Remove the make release target, correct RELEASING.md - #256
Merged
Merged
Conversation
It rewrote lib/Version.php from scratch, losing declare(strict_types=1), and ran git changelog, which prepends a generated changelog above the curated one. Neither is wanted, and removing it drops the only dependency on git-extras. README pointed at it too; both it and RELEASING.md now describe the same process.
MichaelGHSeg
changed the title
bsneed
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make releasedid two unwanted things:printfregeneratedlib/Version.phpfrom scratch, droppingdeclare(strict_types=1);and switching to double quotesgit changelog -tprepended a generated changelog above the curated one3.9.0 was released by hand for those reasons. Removing the target is better than documenting a warning about it, and it drops the repo's only dependency on git-extras (
git changelog,git release), which was an undocumented prerequisite.README.mdpointed at the same target; it now refers toRELEASING.md, which describes the process actually used — Packagist is a metadata index, so the tag is the whole release and there are no credentials involved.