Repository navigation
fix: try the named profile before the EC2 instance role - #175
Merged
Merged
Conversation
On an EC2 host the instance role answered first, so --profile was ignored and the wrong account's Parameter Store was read. With a profile name, the profile providers now come before the instance role. Without one, the order is unchanged. Fixes #171
Owner
Author
|
tested on EC2 Mac and it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--profilenow wins over the EC2 instance role.Before, on an EC2 host the instance role answered first, so the profile was never used and the wrong account's Parameter Store was read. With a profile name, the profile providers now come first and the instance role is the last choice. Without a profile name, the order is unchanged.
Closes #171
Tests:
swift testpasses (210). I did not verify it against a real SSO profile on EC2; a quick check with-p <sso-profile>on an EC2 Mac would confirm it.