fix: Send the action attempt poll id as a query - #636
Open
razor-x wants to merge 2 commits into
Open
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y1RzepycXEYA3LStfjt8cY
razor-x
changed the base branch from
main
to
claude/python-sdk-audit-o2iid9-02-poll-deadline
August 28, 2026 00:15
…laude/python-sdk-audit-o2iid9-03-poll-query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The action-attempt wait loop polled
/action_attempts/getwith a raw POST and a JSON body, while the generatedaction_attempts.getroute uses GET with query params (SDK audit finding M1; same fix as PHP #467). The poll now sendsclient.get("/action_attempts/get", params={"action_attempt_id": ...})in both the sync and async variants, which routes through the same strict URL-search-params serializer as the generated method.Three concrete behavior fixes fall out of matching the generated route's wire shape:
_strict=trueis now sent on every poll (it was silently absent before).Depends on #635 (contains its commit; this PR's own diff shrinks to the
get_action_attemptchange and its tests once #635 merges).Testing
/action_attempts/getwith the id and_strict=truein the query and no request body.'POST' == 'GET'and the retry test fails with the wait aborting onSeamHttpApiError— the audit's exact symptoms.🤖 Generated with Claude Code
https://claude.ai/code/session_01Y1RzepycXEYA3LStfjt8cY
Generated by Claude Code