ci: reject bare dated build ids in the version check (DRIVER-1074) - #1075
Open
nikagra wants to merge 1 commit into
Open
ci: reject bare dated build ids in the version check (DRIVER-1074)#1075nikagra wants to merge 1 commit into
nikagra wants to merge 1 commit into
Conversation
scylladb#1049 admitted a dated build id carrying no label, on the grounds that CCM recognises the form. On the release: route the driver uses it does not: normalize_scylla_version rewrites the '-' to '~' above 5.0 (2022.1 for enterprise), and CCM then resolves no package. Require the label, and drop the dated build the three messages advertise. The accept set is now a strict subset of the merged one, so nothing that resolves today stops resolving. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: QUIET Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Sep 10, 2026
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can turn these tips off under Display preferences |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1049 widened the version grammar to accept a dated build id carrying no label, on the grounds that CCM recognises the form. On the
release:routeCcmBridgealways uses, it does not: scylla-ccm'snormalize_scylla_version(ccmlib/scylla_repository.py:215) rewrites the-to~for majors above 5.0 (2022.1 for enterprise), the published artifact keeps the dash, and the substring selector at:94then finds nothing —ccm createdies at:145withNot expected version number. The principal newly advertised form therefore cannot install on any current major, and as aCASSANDRA_VERSIONit never could: Cassandra CCM 404s on the Apache archive and falls back to a nonexistent git tag.5.1.2-0.20221225.4c0f7ea09893and5.1-0.20221225.4c0f7ea09893are rejected at the gate.5.4.0~dev-0.20230801.37b548f46365and all four tightenings ci: tighten the fully qualified version check (DRIVER-924) #1049 introduced are untouched.Verified:
SERVER_VERSION_REexpands to 254 bytes, byte-identical to #1066, as are the grammar block and all three messages. A 26-case corpus matched with bash=~against the pre-#1044, merged and fixed patterns — every disputed string flips to reject, every installable string stays accepted, and the accept set is a strict subset of both merged lines, so nothing is newly admitted. Each still-accepted case was put through the pinnednormalize_scylla_versionitself: no newly advertised form is uninstallable. No lane exercises a dated id (CI passes aliases only), soSetup ITsis the real gate.Paired with #1066 (3.x), which carries the identical grammar; this one should land first.
Fixes: DRIVER-1074
Refs: #1049