Repository navigation
fix(tutorial): use theme colors for start button - #740
andrewtavis merged 2 commits into
Conversation
|
Thanks so much for the contribution, @Samuel-Francisco-AS! Could you also add a border around the button in dark mode that's the same color as the text? See the designs on Figma :) From there we can bring this in! 🚀 |
|
Really appreciate the screenshots and the care you put into the PR! |
|
Hi @andrewtavis! Thanks for the feedback and the kind words! :) I've added the border using "MaterialTheme.colorScheme.outline" with a width of 1.dp, matching the text color in dark mode. I compared the result with the Figma design and tested it on my Android device. The Gradle checks and debug build completed successfully. I've also updated the dark mode screenshot to show the final result. Thanks again for reviewing my contribution! 🚀 |
|
Sorry for accidentally closing and reopening the PR! This is my first open-source contribution, and I'm still learning the GitHub workflow. Thanks again for your patience, guidance, and encouragement! I really appreciate it! 😊 |
andrewtavis
left a comment
There was a problem hiding this comment.
praise: Thanks so much for a great first contribution and a nice review process, @Samuel-Francisco-AS! Hope we can work with you again :)
Contributor checklist
Description
This PR fixes the dark mode styling of the "Start full tutorial" button in "TutorialHomeScreen.kt".
Previously, the button used "MaterialTheme.colorScheme.primary" for its background and selected black or white text based on the Android system theme.
The button now uses the application's existing theme colors:
This ensures consistent styling with other Scribe buttons in both light and dark modes, while respecting the application's selected theme independently of the system theme.
Unused imports and the unnecessary system-theme check were also removed.
Testing
Screenshots
Dark mode
Light mode
Related issue
Closes #739