Skip to content

feat: add Greek keyboard support - #691

Open
samarthshukla20 wants to merge 8 commits into
scribe-org:mainfrom
samarthshukla20:feat/add-greek-keyboard
Open

samarthshukla20 wants to merge 8 commits into
scribe-org:mainfrom
samarthshukla20:feat/add-greek-keyboard

Conversation

@samarthshukla20

@samarthshukla20 samarthshukla20 commented Aug 30, 2026 •

Copy link
Copy Markdown

Contributor checklist

  • This pull request is on a separate branch and not the main branch
  • I have tested my code with the ./gradlew lintKotlin detekt test command as directed in the testing section of the contributing guide

Description

This pull request adds Greek keyboard support to Scribe Android.

The following changes were made:

  • Added GREEK to ScribeLanguage
  • Added GreekKeyboardIME
  • Registered the Greek keyboard service in the Android manifest
  • Added the Greek input method configuration
  • Added Greek keyboard layouts for:
    • Standard phone layout
    • Tablet layout
    • Layout without period and comma

Testing

The application was built and run successfully through Android Studio and tested on an emulator.

The following functionality was verified:

  • Greek keyboard loads correctly
  • Greek characters can be typed
  • Shift correctly switches between lowercase and uppercase characters
  • Keyboard layouts work correctly

Related issue

Closes #544

@Roniscend

Copy link
Copy Markdown
Collaborator

The lint/test checkbox wasn't checked off , verify that

@samarthshukla20

Copy link
Copy Markdown
Author

Hey @Roniscend, Fixed the Kotlin lint issue in GreekKeyboardIME.kt and pushed the update. The contributor checklist has also been updated accordingly. The required checks now pass locally.

@angrezichatterbox angrezichatterbox added the new keyboard Adding a new language keyboard label Aug 30, 2026
@samarthshukla20

Copy link
Copy Markdown
Author

Hey, are there any new updates regarding merging this pull request?

@samarthshukla20

Copy link
Copy Markdown
Author

Hi! I noticed that the CI workflows are currently awaiting maintainer approval. Could a maintainer please approve the workflows so the checks can run? Thank you!

@andrewtavis

Copy link
Copy Markdown
Member

We're in the midst of preparing for the MVP right now, @samarthshukla20, but good progress has been made and we should be able to get the data for Greek much easier now. Can you fix the errors in CI listed above? We can support as needed :)

@samarthshukla20

Copy link
Copy Markdown
Author

Hi @andrewtavis, I’ve fixed the CI issues mentioned above and pushed the changes in the latest commit (bd431ad).

The remaining CI workflows are currently awaiting maintainer approval. Could you please approve them so the checks can run?

Thanks! 🙂

@samarthshukla20

Copy link
Copy Markdown
Author

hey @andrewtavis , i've tried to fix the CL issues. It requires maintainer approval to run the check. Could you please approve them so the checks can run?

@Roniscend

Copy link
Copy Markdown
Collaborator

hey @andrewtavis , i've tried to fix the CL issues. It requires maintainer approval to run the check. Could you please approve them so the checks can run?

What is CL issue? Is this a typo of CI

@samarthshukla20

Copy link
Copy Markdown
Author

hey @andrewtavis , i've tried to fix the CL issues. It requires maintainer approval to run the check. Could you please approve them so the checks can run?

What is CL issue? Is this a typo of CI

Oh! My bad, it was supposed to CI only.

@andrewtavis

Copy link
Copy Markdown
Member

Just approved the workflows, @samarthshukla20 :)

@Roniscend

Copy link
Copy Markdown
Collaborator

@samarthshukla20 Greek has no AOSP dictionary or NativeSuggestionEngine mapping, so it won't get suggestions. Is that intended for this PR or a follow-up
Also
Greek isn't registered in the language-selection, settings and tutorial screens. Should that be here or in a follow-up issue

@samarthshukla20

Copy link
Copy Markdown
Author

Thanks for reviewing! The current PR focuses on adding the Greek keyboard layout and its basic input functionality.

I haven’t implemented Greek suggestions or registered Greek in the language-selection, settings, and tutorial screens yet. I’m happy to address these in this PR if they’re expected for a complete Greek keyboard contribution, or handle them in follow-up issues if that’s preferred.

Please let me know which approach you’d recommend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new keyboard Adding a new language keyboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add greek keyboard

4 participants