Repository navigation
feat: add Greek keyboard support - #691
samarthshukla20 wants to merge 8 commits into
Conversation
|
The lint/test checkbox wasn't checked off , verify that |
|
Hey @Roniscend, Fixed the Kotlin lint issue in GreekKeyboardIME.kt and pushed the update. The contributor checklist has also been updated accordingly. The required checks now pass locally. |
|
Hey, are there any new updates regarding merging this pull request? |
|
Hi! I noticed that the CI workflows are currently awaiting maintainer approval. Could a maintainer please approve the workflows so the checks can run? Thank you! |
|
We're in the midst of preparing for the MVP right now, @samarthshukla20, but good progress has been made and we should be able to get the data for Greek much easier now. Can you fix the errors in CI listed above? We can support as needed :) |
|
Hi @andrewtavis, I’ve fixed the CI issues mentioned above and pushed the changes in the latest commit ( The remaining CI workflows are currently awaiting maintainer approval. Could you please approve them so the checks can run? Thanks! 🙂 |
|
hey @andrewtavis , i've tried to fix the CL issues. It requires maintainer approval to run the check. Could you please approve them so the checks can run? |
What is CL issue? Is this a typo of CI |
Oh! My bad, it was supposed to CI only. |
|
Just approved the workflows, @samarthshukla20 :) |
|
@samarthshukla20 Greek has no AOSP dictionary or NativeSuggestionEngine mapping, so it won't get suggestions. Is that intended for this PR or a follow-up |
|
Thanks for reviewing! The current PR focuses on adding the Greek keyboard layout and its basic input functionality. I haven’t implemented Greek suggestions or registered Greek in the language-selection, settings, and tutorial screens yet. I’m happy to address these in this PR if they’re expected for a complete Greek keyboard contribution, or handle them in follow-up issues if that’s preferred. Please let me know which approach you’d recommend. |
Contributor checklist
./gradlew lintKotlin detekt testcommand as directed in the testing section of the contributing guideDescription
This pull request adds Greek keyboard support to Scribe Android.
The following changes were made:
GREEKtoScribeLanguageGreekKeyboardIMETesting
The application was built and run successfully through Android Studio and tested on an emulator.
The following functionality was verified:
Related issue
Closes #544