Repository navigation
Conversation
1 of 4 tasks
Owner
|
Thanks @hmoffatt for this. Being able to start and stop the tap from a script is a really useful addition, and sorry it sat here for so long. The project has changed a lot since this was opened (BTX1 support, plus a migration to uv, pytest, ruff and CI in #10), so this branch no longer merges cleanly. Rather than ask you to rebase seven-year-old code, I've re-implemented the feature on the current codebase in #11, with you credited as co-author. It keeps your design (
Reviews and testing on #11 are very welcome, especially if you still have a BTX1. I'll close this PR once #11 is merged. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.