Repository navigation
Fix action-only process journaling - #947
Merged
Merged
Conversation
Keep action supplement process registrations in memory instead of publishing through an uninitialized capture journal, while retaining them in the sanitized action manifest. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the focused action-supplement runner so child process registrations use an action-only in-memory journal instead of the capture worker's uninitialized numbered journal.
Changes
Test plan
RED: pwsh -NoProfile -File Tools\windows\Invoke-MatchedActionSupplement.ps1 against C:\c8 -> empty Path while publishing an uninitialized worker journal
GREEN: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -MatchedScenarioContractOnly -ScratchRoot C:\am7 -> 8/8 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1 -> UiCaptureDriver 182/182 passed; ValidationRunner.Tests.ps1 PASS
Additional validation:
git diff --check, and LF checks -> passed.C:\c8preserved with zero owned survivors; no product action completed.Checklist
git commit -s) per the DCOmake test)make check)