Repository navigation
Fix focused Wire cancellation - #945
Merged
Merged
Conversation
Add the canonical keyboard helper to focused capture, bound the armed-wire wait, refuse wrong focus or modal dialogs, and cover positive and negative cancellation behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the canonical focused-capture Wire flow so Escape cancellation uses the repository's existing native key-down/key-up path instead of calling a method omitted from the focused helper.
Changes
PostKeyboardand foreground-query fragments to the shared focused capture helper.Test plan
RED: pwsh -NoProfile -Command "Import b881b2b UiCaptureDriver.psm1; invoke base Send-CapMatchedEscape" -> GraphCodeUiaGateState does not contain a method named PostKeyboard
GREEN: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -MatchedScenarioContractOnly -ScratchRoot C:\m7 -> 8/8 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1 -> UiCaptureDriver 182/182 passed; ValidationRunner.Tests.ps1 PASS
Additional validation:
pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -RequireRealSeed ... -ScratchRoot C:\v7-> 185/185 passed, 0 failed, 0 skipped.pwsh -NoProfile -File Tools\windows\Tests\Hardening.Tests.ps1-> deterministic fixtures passed, repeated runs 3/3.git diff --check, andgit ls-files --eol-> passed; touched files are LF.Checklist
git commit -s) per the DCOmake test)make check)