Repository navigation
Match Windows cycle card hierarchy to macOS - #942
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Matches the Windows closed-cycle card hierarchy to the current macOS card:
Inspectremains the body action, whilecycle · no entry pointstays in the metadata footer.Changes
Inspectbutton finish without changing unwired recovery controls or terminal chrome.Test plan
RED: & $env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig --test-filter "closed cycle card keeps Inspect" -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus "-I$env:GRAPHCODE_WINGHOSTTY_ROOT\include" -> TestUnexpectedResult at !role.chip_in_detail
GREEN: & $env:GRAPHCODE_ZIG0152 test src\GraphCanvas.zig --test-filter "closed cycle card keeps Inspect" -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus "-I$env:GRAPHCODE_WINGHOSTTY_ROOT\include" -> 1/1 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1 -ScratchRoot C:\gcf3-vr-final -> PASS with UiCaptureDriver 182/182
GraphCanvas.zig: 408 passed, 18 explicit opt-in skips, 0 failed.App.zig: 1587 passed, 18 explicit opt-in skips, 0 failed.C:\gcf3live3: boths-main-cycle-selectedands-main-cycle-unselectedretained stable card/action/reason identities;Inspectended above the footer reason; selected-card activation entered the workspace and returned through Show in Graph. Evidence SHA-256:F18898A5389E86FE1FC6C94E9244A94969E52183C821A78696A9A4A1961E912F.ade1cc346a9546e9393d06a248d145d98f5b09509291ac12ff9ae7dc9a9da9bb/5efa303852c2124615856e6a05f60cc37287ee2d58add0aab13aec2f2b3d6ced; selected BMP/RGB:6de37b5f93934ca9a0d87953dc24b9c1a3c07ef24d8849393e96713ecdeee917/cf35c810ce4a6cb35dbe680cf7379f5750b68a5664e134351b7873fe763ebf81.validate.ps1 -Task windows-shell -SkipTrayLivelimit: the first run refused before UIA launch because its generated lease path was 242/232 characters. Two fresh short-root runs passed all preceding build, unit, contract, hardening, scrubbed-startup, and real-daemon phases, then both stopped in the same unrelated existing full-gate Delete LoopSelectionItemPattern.Select()COM failure atuia-live-gate.ps1:9070; both runs verified complete owned-process cleanup and an unchanged default profile.Checklist
git commit -s) per the DCOmake test)make check)