Repository navigation
Add inline recovery controls to unwired Windows cards - #940
Merged
Merged
Conversation
Expose the existing wire and entry recovery routes directly on Windows graph cards with stable UIA identities and live evidence. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Treat only the four stable unwired recovery prefixes as owned source-supported chrome while retaining unknown and foreign rejection coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
Reacquire the already-requested workspace provider until the exact owned loop bar and toolbar appear or a bounded absolute deadline expires, without replaying navigation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
After an exact metadata observation, wait to an absolute deadline for the already-requested exact owned loop bar and toolbar without replaying input, then re-run the full workspace census. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
coneilen
force-pushed
the
coneilen-fix-unwired-goal-recovery
branch
from
October 28, 2026 04:38
1f8ef63 to
972c625
Compare
Use the card title strip for multi-project native activation so inline recovery buttons cannot intercept workspace navigation, with overlap and invalid-bounds contracts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the macOS-visible inline
Wire it upandMark as entryrecovery controls to unwired Windows graph cards. Both controls reuse the existing context-menu action plumbing and expose stable, invokable UI Automation identities.Changes
bae13e2f360109d617a8d609c145ce9a49996dd4.Test plan
RED: zig test src\GraphCanvas.zig --test-filter "unwired loop card paints inline recovery controls" -> 0 passed; 1 failed because the inline control surface had zero pixels
GREEN: zig test src\GraphCanvas.zig --test-filter "unwired loop card paints inline recovery controls"; zig test src\App.zig --test-filter "unwired inline recovery controls route pointer" -> 1/1 passed in each executable
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1 -> UiCaptureDriver executed=182 passed=182 failed=0 skipped=0
zig test src\GraphCanvas.zig -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -I...\winghostty\include-> 407 passed, 17 skipped, 0 failed (424 executed).zig test src\App.zig ...command fromWindowsShell.Tests.ps1-> 1582 passed, 17 skipped, 0 failed (1599 executed).pwsh -NoProfile -File Tools\windows\Tests\AccessibilityProvider.Native.Tests.ps1-> 240 checks, 0 failures.pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -MatchedScenarioContractOnly -ScratchRoot C:\gcf1-...-> 8 passed, 0 failed.pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1-> 182 passed, 0 failed, 0 skipped.Wire it upenteredChoose a target loop to wire this entry;Mark as entryreportedMarked as an entry for this session, removed both controls, preserved the same card, and verified zero surviving owned processes.validate.ps1 -Task windows-shell -SkipTrayLive -ShellPart integrationpassed build, smoke, daemon roundtrip, F2 New Tab, and F1 card/UIA evidence on three attempts, then the local desktop consistently rejected a later unrelatedSelectionItem.Select()call during delete-target setup. Cleanup was verified each time. Fix Windows terminal chrome density at high DPI #941's exact-head CI passed the same integration gate after its startup fix; Add inline recovery controls to unwired Windows cards #940 exact-head CI is the final full-gate authority after this rebase.Checklist
git commit -s) per the DCOmake test) — not run; this is a Windows-only change and the registered Windows suites above passedmake check) — not run; macOS Swift style surfaces were not changed, and the changed Zig files were formatted with pinnedzig fmt