Repository navigation
Fix numbered journal validation deadline - #939
Merged
Merged
Conversation
Keep the one-second Open/Copy/retry budget separate from the caller cleanup deadline after immutable bytes are copied. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Separates the numbered-journal one-second Open/Copy/retry budget from the absolute caller and cleanup deadline after immutable bytes are copied. This prevents valid large terminal journals from being refused while preserving all I/O, hard-deadline, identity, mutation, and cleanup refusals.
Changes
CLEANUP_UNPROVEN/UNPROVEN.Test plan
RED: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -JournalFirstOpenContractOnly -ScratchRoot D:\gcr-red-08572544 -> JournalUnavailable sequence=2 after openMs=0.876 copyMs=3.162 totalMs=2471.853
GREEN: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -JournalFirstOpenContractOnly -ScratchRoot D:\gcr-green-d6b488af -> 2/2 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -ScratchRoot D:\gcu-full-8d3eb9ad -PrebuiltFixtureManifest D:\gcu-prep-0c80633b\fixtures.json -PrebuiltFixtureManifestSha256 80E8E7A9509C7A18C314C4BC369DA3C4DA5F9A65562564A010B1411EB17F8258 -> 182/182 passed, zero skips
Additional validation:
035311740FD7A7B15BAFB499F24E073FAB2C436711FA6D9A0D5EAA9267F6EE31.Tools\windows\Tests\ValidationRunner.Tests.ps1: UiScenario 166/166 and nested UiCaptureDriver 182/182 passed.Tools\windows\validate.ps1 -Task hardening: deterministic repeated runs 3/3 passed.deb35d9b696a6466095feb416ed4077864be3d35: 36/36 checkpoints, 22/22 seeds, 2/2 Restarts, one before-to-after transition, zero captures/images/PNGs,RELEASED_ZERO_SURVIVORS, andKERNEL_EXIT_AND_EOF_PROVEN.1F156EE6D8309EE4F480DA9C1EDA439D9D08A933D33973F16AA05CA0E4BB587E; release SHA-256BE84D7A039E91A216817F7174BB95CD96C96BE5526462F2B953D8D406F5A1221; checkpoint aggregate SHA-256F58D3032727FC66416747C7CE96EE5FB006733A75903FB9DBA4A68B3242F85DB; terminal journal SHA-25600BB1E4CCDD5841D63B9D0C00B5510B1169E24C5C74061AF05874B8EB8BD6FBA.git diff --check, and LF checks passed.make test/make checkwere not run because this change is confined to Windows capture tooling, tests, and documentation.Checklist
git commit -s) per the DCOmake test)make check)