Repository navigation
Fix C8R many-tab UIA selection - #935
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the C8R
s-tabs-many-firstfailure by deriving the actual contiguous visible tab roster and using an exact stable-ID bridge before reacquiring and selecting the first tab. The product/provider contract is unchanged: hidden overflow tabs remain unpublished, tab names and IDs remain exact, and tab rows do not claim the sidebar-only ScrollItem pattern.Changes
Test plan
RED: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -MatchedScenarioContractOnly -ScratchRoot .build\c8r-many-tabs-red2 -> 6/8; s-tabs-many-first failed UIA element 'Shell' did not become available before the reserved deadline.
GREEN: pwsh -NoProfile -File Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -MatchedScenarioContractOnly -ScratchRoot .build\c8r-many-tabs-green5 -> 8/8 passed.
REGRESSION: UiCaptureDriver D:\gcf3; real-zmx D:\gcr3; ValidationRunner; validate.ps1 -Task hardening -> 182/182, 185/185, 166/166 plus nested 182/182, and hardening 3/3 passed; no capture or lease used.
Additional checks:
git diff --checkpassed.git ls-files --eolreported LF for all changed files.C:\e8\runtime\zmx.exeSHA-25665E585375017EB2344655DAF2014AE8B6C5015923A0B3803C3890C83D4A1F702.Checklist
git commit -s) per the DCOmake test)make check)make testandmake checkare macOS gates and were not run for this Windows-only capture-tooling change; the Windows validation matrix above passed.