Repository navigation
Fix DPI192 connector drag UIA gate - #934
Merged
Merged
Conversation
Freeze exact connector endpoint geometry after Actual Size, reject foreign coordinate spaces and preexisting dialogs, and drop within the target card's visible graph/client intersection. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
coneilen
force-pushed
the
coneilen-fix-connector-drag-uia
branch
from
October 26, 2026 15:40
4e07b00 to
e0353c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Windows live UIA gate's DPI192 connector-to-target drag cutoff without changing GraphCanvas, mouse routing, native edge forms, or #778 context-menu product behavior. The gate now freezes exact owned card geometry after Actual Size and drops within the target card's visible graph/client intersection instead of using an off-viewport full-card center.
Changes
Create or edit edgesheet and locked endpoint fields as the success identity.Test plan
RED: pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1 -> Get-ConnectorDragSnapshotDecision was not recognized at the DPI192 connector case
GREEN: pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1 -> UiScenario 166/166 and UiCaptureDriver 182/182 passed
REGRESSION: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task hardening -> repeated-runs PASS 3/3
FOCUSED_CONNECTOR_DRAG_CONTRACT=PASS positive=1 cutoff=1 negatives=6 dpi=192.Tools\windows\uia-live-gate.ps1andTools\windows\Tests\ValidationRunner.Tests.ps1-> passed.git diff --checkand LF checks for both changed files -> passed.4e07b00c5a94df748b08e279ef371d7832f9c9a0-> all GitHub checks completed successfully or were intentionally path-gated skipped, including Windows shell integration, three unit shards, packaging, Windows spikes, deterministic hardening on Windows 2022/2025, DCO, TDD evidence, and privacy scan.origin/mainat1219d228473238c168d0065def34d3baafc57b27; stable patch ID remainedcc28f2557644a6bc85dd404f32e8b950d5f16a4f.pwsh -NoProfile -File Tools\windows\uia-live-gate.ps1 -Shell graphcode-windows\zig-out\bin\graphcode-windows.exe -Zmx D:\gcp-5c0\zmx\zig-out\bin\zmx.exewithTEMP=D:\t5c3-> connector drag passed at DPI192 with exact locked source/target endpoints; the gate advanced to the later unrelatedlane cards do not normalize to the shared 250x96 geometrycutoff before Windows parity: Context menus carry the macOS item set and grouping #778 context-menu coverage.[1229,853]; old target center[1759,853]outside the client/graph; corrected visible target[1584,853]; no preexisting dialog; coordinate spacephysical-screen.e0353c490d2aa01cbc986d3da20e3a9384b3e24d.Checklist
git commit -s) per the DCOmake test)make check)