Repository navigation
Fix real-zmx normal lifecycle preflight - #933
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the C8R real-zmx normal-target preflight race where an owned short-lived process exited after worker journal publication but before the supervisor could retain its handle. The supervisor now defers only that exact typed/absent-metadata state to the worker's final kernel-exit and EOF/file-closure proof.
Changes
Test plan
RED: pwsh Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -ScratchRoot C:\x9 -RequireRealSeed -RealSeedContractOnly -> 3 executed, 2 passed; normal failed because the journal adoption decision helper was missing
GREEN: pwsh Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -ScratchRoot C:\m7 -RequireRealSeed -RealSeedContractOnly -> 3 executed, 3 passed, 0 failed
REGRESSION: pwsh Tools\windows\Tests\UiCaptureDriver.Tests.ps1 -ScratchRoot C:\a6 -RequireRealSeed -> 185 executed, 185 passed, 0 failed, 0 skipped
pwsh -NoProfile -File Tools\windows\Tests\ValidationRunner.Tests.ps1-> PASS; UiScenario 166/166 and UiCaptureDriver 182/182 with zero skips.pwsh -NoProfile -File Tools\windows\validate.ps1 -Task hardening-> PASS; deterministic repeated runs 3/3.git diff --checkandgit ls-files --eolfor all changed files -> PASS; LF retained.pwsh -NoProfile -File Tools\tdd\Tests\TddEvidence.Tests.ps1-> PASS.Checklist
git commit -s) per the DCOmake test)make check)