Repository navigation
Conversation
|
/devin review |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Agent-authoring references packages/agent-core/skills/sapiom-agent-authoring/SKILL.md, packages/agent-core/templates/*/.claude/skills/sapiom-agent-authoring/SKILL.md, plugins/sapiom/skills/sapiom-agent-authoring/SKILL.md |
Removes links to retired MCP setup, credentials and configuration, and call-surface pages. The capabilities references remain. |
Harness documentation surfaces packages/harness/web/src/lib/docs.ts, packages/harness/web/src/components/NewSessionComposer.tsx, packages/harness/web/src/styles.css, packages/harness/web/e2e/*, packages/harness/web/src/lib/palette.test.ts, scripts/agent-studio-terminology-allowlist.json |
The documentation list retains the AI models page. The first-run footer loses its documentation link. Related tests, styles, and the terminology allowlist are updated. |
Package notices and prompt .changeset/drop-retired-docs-links.md, packages/agent/README.md, packages/analytics-core/src/analytics.ts, packages/harness/src/profiles/default.ts, packages/harness/src/profiles/default.test.ts |
Removes the “Using signals” link, the telemetry documentation URL, and the call-surface guide URL from the default prompt. Updates the prompt digest and related test claims. The changeset records patch releases for four packages. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: gwitwer
Merge Risk: 
3201b
-
The documentation-link removals are consistent with the stated retirement changes and are ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Resolution Docstring Coverage Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 7 files. (6 skipped: 6 … Write docstrings for the functions missing them to satisfy the coverage threshold. -
Check name Status Explanation Title check The title clearly and concisely describes the primary change: removing links to retired documentation pages. Description check The description follows the required template, explains the problem and scope, documents validation and test coverage, identifies the unrun Playwright tests, records release impact and the changeset, … Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description follows the required template, explains the problem and scope, documents validation and test coverage, identifies the unrun Playwright tests, records release impact and the changeset, and completes the security, AI assistance, and checklist sections.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 7 files. (6 skipped: 6 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit hops through pages gone,
The retired links have all moved on.
AI models stay in view,
Capabilities remain there too.
I nibble clover, pleased and spry.
Comment @coderabbitai help to get the list of available commands.
|
Starting Devin Review. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
The skill and its three synced copies linked the MCP setup, credentials, call-surface, authoring-guide and quick-start pages of docs.sapiom.ai, which were retired. The /capabilities links stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The bundled system prompt's call-surface guide line, four of the five help-palette pages (agents and workflows quick starts, both MCP setup pages) and the first-run "Read documentation" link all pointed at docs pages that no longer exist. The palette keeps AI models, a capability page. The prompt snapshot digest moves with the prompt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The @sapiom/agent README linked a signals guide that is gone, and the first-run telemetry notice linked a /telemetry page that never existed. The notice still names the opt-out variable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The comments explained a five-page help list and a footer with a docs link. After the retired pages came out they describe one page and no link, so they now say what remains and why the rest went. Kept apart from the link removal because it changes what the comments claim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
8d2b20f to
3350faa
Compare
The help palette no longer lists the workflows quick start, so the allowlist entry for its title and URL matched nothing and failed `pnpm terminology:check`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
/devin review |
|
Starting Devin Review. |
Primary change type
Problem and motivation
The agent quick start, authoring guide, MCP setup, call-surface, credentials, signals and workflows pages on docs.sapiom.ai were retired on 2026-10-23. Several places still sent people and agents to those pages, which now return 404:
@sapiom/agentREADME.The first-run telemetry notice also linked a
/telemetrypage that never existed.Summary and scope
packages/agent-core/skills/sapiom-agent-authoring/SKILL.md): links to retired pages removed. The result is copied verbatim to the two scaffold templates and the plugin, asskill-sync.test.tsrequires.GET /v1/harness/system-prompt.default.test.tsmoves with the prompt.@sapiom/agentREADME: drops the signals-guide link.FIRST_RUN_NOTICEdrops the/telemetryURL and keeps the opt-out variable./capabilitieslinks.Out of scope:
packages/mcp/src/instructions.generated.tsand the skill's authoring-rules stamp. Both snapshot what the backend serves, so they get regenerated after the backend's matching text change deploys (scripts/mcp-instructions-snapshot.mjs,scripts/authoring-rules-stamp.mjs --from-served).docs.sapiom.ai/links (SDK READMEs,DOCS_SITE). They still resolve.Related work
Related issue or discussion: SAP-4074.
Validation
I didn't run the Playwright specs I edited (
web/e2e/welcome.spec.ts,web/e2e/palette-search.spec.ts) locally. CI runs them.Tests and documentation
default.test.ts, which drops the guide line;models;Compatibility and release impact
.changeset/drop-retired-docs-links.md, patch for agent-core, agent, harness and analytics-core).Security
will follow the
Security Policy for
private reporting.
AI assistance
Claude Code made the edits and ran the checks listed above, working from a link inventory of the affected files.
Checklist
CONTRIBUTING.md, and this contribution follows the direct-PR or issue-first policy.any N/A checks above.
🤖 Generated with Claude Code
Summary by CodeRabbit