Repository navigation
Conversation
…meRole
The 4 trust-policy properties on AssumeRoleStatement used exact string
match ("sts:assumerole" not in lowercase_actions) which missed wildcard
actions like sts:*, sts:AssumeRole*, and *. The most permissive trust
policies (wildcard action + Principal "*") were incorrectly reported as
clean.
Added _allows_assume_role() helper using fnmatchcase for case-insensitive
glob matching, and replaced all 4 duplicate checks with calls to this
helper.
Added tests for wildcard and non-matching action patterns.
Fixes salesforce#645
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role_assumable_by_any_principal,role_assumable_by_cross_account_principals,role_assumable_by_compute_services,role_assumable_by_any_principal_with_conditions) used exact string match forsts:AssumeRole, missing wildcard actions likests:*,sts:AssumeRole*, and*._allows_assume_role()helper usingfnmatchcasefor case-insensitive wildcard matching.Test plan
pytest test/scanning/test_trust_policies.pypassestest_assume_role_wildcard_actionsverifiessts:*,sts:AssumeRole*, and*are all detectedtest_assume_role_non_matching_wildcard_actionsverifiess3:*,ec2:*,sts:AssumeRoleWithSAMLare not matched