Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified in the CI configuration, packaging flow, or isolated smoke checks.
No open issues 🎉
What changed in this PR
Adds scheduled compatibility checks and isolated package smoke tests for the Python client.
Changes:
- Runs CI on pull requests, master pushes, weekly schedules, and manual triggers.
- Builds and validates wheel and source distributions using local requests.
- Modernizes test tooling and documents tested Python versions.
| File | Description |
|---|---|
| tox.ini | Runs unit tests and package smoke checks. |
| test/test_sailthru_client.py | Uses standard-library mocks. |
| test/smoke-package.py | Tests the installed client against a loopback server. |
| scripts/test-package.py | Builds and validates both distributions in isolated environments. |
| README.md | Documents compatibility targets and test commands. |
| pyproject.toml | Declares the package build backend. |
| .github/workflows/code-check.yml | Adds scheduled and event-driven Python compatibility checks. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
master, weekly schedules, and manual execution.Why
INTST-1757 requires scheduled compatibility checks to catch runtime issues without waiting for library changes.
The existing test configuration targeted obsolete Python versions. The updated pipeline runs the suite on modern runtimes and verifies that both distribution formats can be installed, imported, and used for a basic request.
Verification
Pending after merge