Repository navigation
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
🟢 Approval recommended
Static review found no blocking defects; execution was not verified.
No open issues 🎉
What changed in this PR
Adds scheduled Java compatibility checks and verifies that the packaged client works in a standalone consumer.
Changes:
- Runs CI on JDK 17, 21, 25, and the latest stable Temurin release.
- Adds a package smoke test using a local HTTP server.
- Documents local verification and scheduled CI behavior.
| File | Description |
|---|---|
src/it/package-smoke/src/main/java/PackageSmoke.java |
Validates JAR loading, request fields, and response parsing. |
src/it/package-smoke/pom.xml |
Configures the standalone smoke consumer. |
README.md |
Documents compatibility checks and local commands. |
pom.xml |
Configures Surefire and binds package smoke checks to verify. |
.github/workflows/code-check.yml |
Adds multi-JDK CI with weekly and manual triggers. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
main, weekly scheduled checks, and manual execution.Why
INTST-1757 requires compatibility checks that run even when the library has no new commits.
The Java client had unit tests but no automated CI workflow. Scheduled checks against the latest stable runtime help expose compatibility problems before customers encounter them.
The package smoke check also verifies the built artifact independently of the development checkout.
Verification
Verification:
The smoke check uses dummy credentials and a loopback server. No package was published.
Pending after merge