Repository navigation
Console: daisyUI components + outer theme, Lucide icons, no overflow - #41
Merged
Merged
Conversation
* Re-adopt daisyUI 5 (Tailwind v4 plugin, console-only scope, @source '.'): custom 'outer' (default) + 'outer-dark' (prefersdark) themes matching the reference (soft gray canvas, white panels, near-black primary/neutral, radius-box 1.25rem, muted status colors). Components used: menu (sidebar, dropdown popovers), card, stats/stat, badge (badge-soft pills), table + table-fixed w/ colgroup, join (range picker), tabs-box (mobile view tabs), btn, drawer + drawer-toggle/content/side/overlay (mobile sidebar, md:drawer-open on desktop), dropdown, tooltip, skeleton, alert, collapse (deploy rows), kbd (Esc hints), loading, divider, indicator (rail status dots, error count), avatar (rail tiles, account). Deleted the custom CSS daisyUI replaces; kept layout glue, charts, log list, app-tile tints. * Lucide via the 'lucide' package's IconNode exports ([tag, attrs][] nodes rendered through a tiny Ilha component using ilha's h(); pinned 1.61.0): no CDN, no createIcons DOM scanning, CSP-safe. OuterMark stays custom. * Overflow impossible: truncate + min-w-0 on every flex/grid text child, table-fixed with column widths, break-words only for logs/deploy message (break-all for unbroken error runs), title on everything truncated. Main panel and grids fill available width (drawer-content min-w-0, stats stack below xl). * CSP unchanged, zero style= attributes. Verified: bun build + validate clean; Playwright Chromium vs real router with seeded absurd data (500-char summaries, 300-char paths, 63-char slugs, long errors/secrets): Overview/Actions/Errors/Deploys (expanded)/ Secrets at 1440 and 1024, mobile 390 drawer open in /tmp/outer-console-v3-*; no horizontal document scroll, no element box outside its panel, zero CSP violations and console errors. cargo fmt/clippy -D warnings/test green (438 passed). Harness test deleted after verification.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner: (1) long cells overflowed and broke the console layout, (2) use Lucide icons, (3) use daisyUI components instead of custom ones, with a theme matching the current look.
truncate,min-w-0on flex/grid children,table-fixed+colgroupwidths) and keeps the full text intitle; deploy errors wrap (break-all); the main panel fills the width; stats go horizontal fromxl. Verified in Chromium with absurd data (500-char summaries, 300-char paths, 63-char slugs, a 1,500-char deploy error) at 1440, 1024 and 390 px: no horizontal document scroll, no element outside its panel, zero CSP violations or console errors.lucide1.61.0): icon nodes rendered through a tiny Ilha component (@lucide/astroonly works in.astrofiles;createElement/createIconsare DOM-based and would fight hydration and the CSP). The Outer mark stays custom.menu,card,stats,badge,table,join,tabs,btn,drawer(mobile sidebar),dropdown(account),tooltip,skeleton,alert,collapse(deploy rows),kbd,loading,divider,indicator(status dots, error count),avatar(rail tiles). Custom CSS is now layout glue, the SVG charts, the log list and tile tints.outer(default: soft-gray canvas, white panels, near-black primary,--radius-box1.25rem) andouter-dark(prefersdark).438 tests pass; Blume build and validate pass.