Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__checked_int_from_numberbuiltin at immutable call index0xFF90, with matching std/no-std dispatch and generated ID mirror. Tagged integers are preserved; finite, integral, exactly representable floats in the signed 64-bit range convert; type, arity, and assertion failures retain their established error paths.These two Core capabilities are needed together before the ES5.1 frontends can replace their fixed Core dependency and exercise the prelude.
Verification
On base
2f433edab3f1907e8cb060e901357d7e2af016ce:cargo fmt -- --check, no-std and runtime-onlycargo check, library Clippy with-D warnings, andgit diff --checkpassed.This PR is intentionally left open; no merge is requested.
Follow-up: reused-slot division hints
Dropwith typing so a recycled physical slot cannot retain a dead Float schema. Capture explicit declaration schemas before compaction in a compiler-private assignment sidecar; the publicStmt,FrontendIr, and VMBC shapes stay unchanged.TypeMismatch("float"); nested typed-number assignments in if/Result-match branches narrowed to Int/Float. The focused local checks on this commit passed: 9 runtime and 9 no-default-runtime tests, 1 closure-clone test, 7 type-inference tests, plus Clippy-D warnings, fmt, and diff checks. Independent scoped re-review found no blocker.