Repository navigation
fix(compiler): follow Core 2f433eda and adopt VMBC v14 - #2
Merged
Merged
Conversation
Bump the vm (pd-vm) pin in native/pd-vm-compiler from b1d6cff to fc8b0c81 and report the migration surface rather than finishing it. cargo update -p pd-vm --precise also moves pd-host-function and pd-host-schema, and leaves a second copy of both: pd-edge-abi 5f4f889 (ABI 25) still pins pd-host-function at b1d6cff, and no pd-edge revision pins the new core yet (master c898672 is ABI 25 with the same old pin). cargo check --locked --all-targets surfaced exactly two E0004 non-exhaustive matches on the new Unit/Option/Result variants of HostTypeSchema and TypeSchema. Encode them with the upstream core tag values (host 16/15/14, types 20/19/18); no edge-abi or symbol incompatibility is involved. The wire format itself moved to VMBC v14 with a new trailing ret_cleanups section, and PdVm.Compiler/PdVmVmbcReader.cs still requires version 13 and rejects trailing bytes, so the stack is not mergeable until pd-edge cuts an ABI 26 revision, wire.rs ports write_ret_cleanups, and the managed reader learns v14. All of that is enumerated in docs/native-core-pin-probe-fc8b0c81.md. cargo check/fmt/clippy pass at this pin; cargo test does not, for the documented reasons.
The migration is complete: the compiler pins core 8db45832 and edge ABI 26, and the reader consumes VMBC v14. The probe notes still described the bump as blocked and would mislead readers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core publishes the VMBC codec outside the
runtimefeature, so the native compiler callsvm::encode_programdirectly.pd-vmto Core2f433edab3f1907e8cb060e901357d7e2af016ceandpd-edge-abito9a9ee3303a17fcf65893f04b1ce4e4df9d7f50c1(ABI 26).native/pd-vm-compiler/src/wire.rs; encode via the Core codec (v14 header, empty ret-cleanup section).__map_editbuiltin.nullto()/Option; the HTTP proxy example matchesSome(text)/Nonedirectly.Result::Ok/Result::Errstay qualified.PdVm.Runtimeunit handling and callable/callback updates required by the new Core.Windows CI repair (current head):
nullto(); keep C# nulls unchanged. Update the RustScript syntax examples in both docs, usingOption<T>/Nonefor optional values.9a9ee3303a17fcf65893f04b1ce4e4df9d7f50c1.Current-head local verification:
cargo fmt --all --check --manifest-path native/pd-vm-compiler/Cargo.toml— exit 0.cargo clippy --locked --manifest-path native/pd-vm-compiler/Cargo.toml -- -D warnings— exit 0.cargo test --locked --manifest-path native/pd-vm-compiler/Cargo.toml— exit 0; 17 tests passed.cargo build --locked --release --lib --manifest-path native/pd-vm-compiler/Cargo.toml— exit 0..rssfiles returnsNo such file or directorywithout the CLR-generatedSystemoverlay modules. Windows .NET CI exercised their source-wrapper compilation and WinForms callbacks successfully (pull_request run 43760826974; both Windows and Ubuntu jobs passed). The local .NET Docker invocation was terminated after an MSBuild named-pipe/SocketException in its read-only environment; it provides no .NET test result for this head.