Repository navigation
feat: brand colors, live light/dark, step bar polish, seek fix and flow titles - #15
Merged
Merged
Conversation
each() re-inserted every view on each update, so the segments, updated every frame during a video step, were detached mid-click and the click was dropped. Only out-of-place views move now.
Equal-width segments (no reflow on step change), eased fills and show/hide, thicker segments with a step label on hover, a fixed-width counter, and a dense scrubber from 12 steps.
hotspotStyle forces the hotspot/tooltip colors over the recorded ones. appearance (light, dark or auto for prefers-color-scheme) overrides the demo's. Both change live through Player.setHotspotStyle()/setAppearance() and the React/Vue props, without remounting.
A flow's optional title travels in the .osrec's direction and the editor opens the demo with it (the player's browser bar, the export's file name). The skill asks the agent for a short, descriptive one.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Player improvements for embedding demos in a host app (brand colors, light/dark that follows the site, a fix for seeking during video, a polished step bar), plus demo names from recorder flows.
Fix: navbar segments ignored clicks while a clip played
each()(packages/player-core/src/dom/h.ts) re-inserted every view on each update. While a video step plays, the segments update every frame, so their buttons were detached mid-click and a real (multi-frame) click was dropped. Only the arrows worked. Now only out-of-place views move. This affects every consumer (editor preview, React, Vue).Step bar polish
prefers-reduced-motionbranch).hotspotStyleandappearanceoptionshotspotStyle: { bgColor?, textColor? }overrides every step's hotspot and tooltip colors, whatever the demo was recorded with.appearance: "light" | "dark" | "auto"overrides the demo's own."auto"follows the viewer'sprefers-color-schemeas it changes.Player.setHotspotStyle()/setAppearance()and the React/Vue props, without remounting or restarting the demo.Recorder: name the demo from the flow
A flow can set
"title": "Create an invoice". It travels in the.osrec's direction and the editor opens the demo with it, so it's what the player's browser bar shows and what names the export. The skill asks the agent for a short task name (2–5 words, the app's own words, no "Demo of…").Test plan
pnpm run ci(Biome, build, types, tests, size)each()leaves in-place views untouched, dense navbar, overlay color override, live appearance/colors without remount (core + React + Vue),"auto"following and unsubscribing fromprefers-color-schemeexportFileand the.osrecround trip, and the e2e opens the editor with it