Repository navigation
Conversation
Calling `LocalSource::new` with an empty `backup_paths` slice caused an immediate out-of-bounds indexing panic at `&backup_paths[0]`. Use `backup_paths.split_first()` to ensure at least one path is provided before initializing `WalkBuilder`, returning an `InvalidInput` error otherwise. Add a unit test verifying that empty backup paths return an error instead of panicking. Reported-by: BS.ehlas.cz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
LocalSource::newis called with an emptybackup_pathsslice, indexing&backup_paths[0]panics with an out-of-bounds error (the len is 0 but the index is 0).Root Cause & Fix
LocalSource::newassumed thatbackup_pathsis never empty when initializingWalkBuilder::new(&backup_paths[0]).This patch:
backup_paths.split_first()to validate that the slice is not empty.RusticErrorof kindErrorKind::InvalidInputif no paths are provided.LocalSource::newto list the empty path error condition.test_local_source_new_empty_backup_paths) incrates/core/src/backend/ignore.rsensuring anInvalidInputerror is returned whenbackup_pathsis empty.