Skip to content

Remove windows-targets dependency from the root workspace - #163252

Open
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:reduce_windows_targets_deps
Open

Remove windows-targets dependency from the root workspace#163252
bjorn3 wants to merge 1 commit into
rust-lang:mainfrom
bjorn3:reduce_windows_targets_deps

Conversation

@bjorn3

@bjorn3 bjorn3 commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

View all comments

By updating backtrace, curl and stacker. Also update flate2 and miniz_oxide to avoid introducing a duplicate dependency.

Part of #156459

@rustbot

rustbot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 24, 2026
@rustbot

rustbot commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Mark-Simulacrum

@bjorn3 bjorn3 mentioned this pull request Sep 24, 2026
Open
20 of 35 tasks
@Mark-Simulacrum

Mark-Simulacrum commented Sep 24, 2026

Copy link
Copy Markdown
Member

@bors r+

@rust-bors

rust-bors Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

📌 Commit ce2779d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 24, 2026
@clubby789

clubby789 commented Sep 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

iirc this backtrace version has issues on Windows (#150225 (comment)), just going to check

@bors try jobs=x86_64-msvc-ext2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 24, 2026
@bors
Auto merge of #163252 - bjorn3:reduce_windows_targets_deps, r=<try>
126a44d 
Remove windows-targets dependency from the root workspace


try-job: x86_64-msvc-ext2
@rust-bors rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 24, 2026
@rust-bors

rust-bors Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 126a44d failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clubby789

clubby789 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@bors try jobs=test-x86_64-msvc-ext2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Sep 24, 2026
@bors
Auto merge of #163252 - bjorn3:reduce_windows_targets_deps, r=<try>
6f5cb62 
Remove windows-targets dependency from the root workspace


try-job: test-x86_64-msvc-ext2
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 24, 2026
@JonathanBrouwer
Rollup merge of rust-lang#163252 - bjorn3:reduce_windows_targets_deps…
be4bbc5 
…, r=Mark-Simulacrum

Remove windows-targets dependency from the root workspace

By updating backtrace, curl and stacker.

Part of rust-lang#156459
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 24, 2026
Closed
@rust-bors

rust-bors Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 6f5cb62 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bjorn3

bjorn3 commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

@bors r-

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 24, 2026
@rust-bors

rust-bors Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

This pull request was unapproved.

This PR was contained in a rollup (#163260), which was unapproved.

View changes since this unapproval

@clubby789

clubby789 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

rust-lang/backtrace-rs#741 does contain a fix for this (rust-lang/backtrace-rs#745); there just hasn't been a release in a while

@bjorn3

bjorn3 commented Sep 24, 2026

Copy link
Copy Markdown
Member Author

@workingjubilee would it be possible to get a new backtrace-rs release?

@bjorn3 bjorn3 added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 2, 2026
@workingjubilee

workingjubilee commented Oct 26, 2026

Copy link
Copy Markdown
Member

Hello, sorry.

@workingjubilee

workingjubilee commented Oct 27, 2026

Copy link
Copy Markdown
Member

backtrace 0.3.77 cut, lmk if it doesn't work.

@bjorn3
bjorn3 force-pushed the reduce_windows_targets_deps branch from ce2779d to 5987d50 Compare October 27, 2026 11:20
@rustbot

rustbot commented Oct 27, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bjorn3

bjorn3 commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=test-x86_64-msvc-ext2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Oct 27, 2026
@bors
Auto merge of #163252 - bjorn3:reduce_windows_targets_deps, r=<try>
6c8fd4d 
Remove windows-targets dependency from the root workspace


try-job: test-x86_64-msvc-ext2
@bjorn3
Remove windows-targets dependency from the root workspace
ece16b3 
By updating backtrace, curl, stacker. Also update flate2 and miniz_oxide
to avoid introducing a duplicate dependency.
@bjorn3
bjorn3 force-pushed the reduce_windows_targets_deps branch from 5987d50 to ece16b3 Compare October 27, 2026 11:30
@bjorn3

bjorn3 commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=test-x86_64-msvc-ext2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Oct 27, 2026
@bors
Auto merge of #163252 - bjorn3:reduce_windows_targets_deps, r=<try>
d86eed2 
Remove windows-targets dependency from the root workspace


try-job: test-x86_64-msvc-ext2
@rust-bors

rust-bors Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: d86eed2 (d86eed260d8964f941adb15c8deca2ca4c87840e)
Base parent: 16d1ffa (16d1ffac17ad8b739e32483ac2e65fe7e1804977)

@bjorn3

bjorn3 commented Oct 27, 2026

Copy link
Copy Markdown
Member Author

Thanks Jubilee! Looks like it worked.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 27, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bjorn3 @rustbot @Mark-Simulacrum @clubby789 @rust-log-analyzer @workingjubilee