Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is my first PR to the reference, apologies if this should have gone through an issue or more discussion before opening
Add a line in
unsafety.mdandinline-assembly.mdpointing out thatasm!requiresunsafe.This is already briefly mentioned in
inline-assembly.md, but feels very off-handed and lacklustre:Unrelatedly; i believe the header level for
asm.validityis wrong and should only be anh2? since it currently sits inside "Rules for naked inline assembly", while mentioningasm!. note that it is immediately followed by "Directives support", which also seems to need to be ah2rather thanh3. happy to do those changes here or separately.disclaimer i have very little knowledge on
asm!-- i primarily care about the documentation surroundingunsafeto be exhaustive.