Skip to content

fix(GeneralInvite): invite_again 勾选框 interval 改为 3 #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
runhey merged 1 commit into from
Oct 31, 2026
+1 −1
Merged

fix(GeneralInvite): invite_again 勾选框 interval 改为 3 #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tasks/Component/GeneralInvite/general_invite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ def invite_again(self, default_invite: bool=True) -> bool:
self.screenshot()
if self.appear(self.I_UI_CHECK):
break
if self.appear_then_click(self.I_UI_UNCHECK, interval=1):
if self.appear_then_click(self.I_UI_UNCHECK, interval=3):

@sourcery-ai sourcery-ai Bot Oct 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 中等 · 默认邀请仍处于启用状态

当 default_invite 为 false，且对话框需要超过一秒才会反映复选框点击操作时，default_invite=False 分支会调用 appear_then_click(self.I_UI_CHECK, interval=1)，因此在界面更新之前，过时的已勾选图像会再次被点击，导致复选框最终处于错误状态。

请增大 default_invite=False 分支中 I_UI_CHECK 点击操作的间隔，以便界面有时间更新后再进行下一次检查。

面向 AI 代理的提示 
在 `tasks/Component/GeneralInvite/general_invite.py` 第 510 行：

**默认邀请仍处于启用状态**

当 `default_invite` 为 false，且对话框需要超过一秒才会反映复选框点击操作时，`default_invite=False` 分支会调用 `appear_then_click(self.I_UI_CHECK, interval=1)`，因此在界面更新之前，过时的已勾选图像会再次被点击，导致复选框最终处于错误状态。

请增大 `default_invite=False` 分支中 `I_UI_CHECK` 点击操作的间隔，以便界面有时间更新后再进行下一次检查。
Original comment in English

🟡 Medium · Default invitation remains enabled

When default_invite is false and the dialog takes more than one second to reflect a checkbox click, the default_invite=False branch calls appear_then_click(self.I_UI_CHECK, interval=1), so a stale checked image is clicked again before the UI updates and the checkbox ends in the wrong state.

Increase the interval for the I_UI_CHECK click in the default_invite=False branch so the UI can update before it is checked again.

Prompt for AI agents 
In `tasks/Component/GeneralInvite/general_invite.py` at line 510:

**Default invitation remains enabled**

When `default_invite` is false and the dialog takes more than one second to reflect a checkbox click, the `default_invite=False` branch calls `appear_then_click(self.I_UI_CHECK, interval=1)`, so a stale checked image is clicked again before the UI updates and the checkbox ends in the wrong state.

Increase the interval for the `I_UI_CHECK` click in the `default_invite=False` branch so the UI can update before it is checked again.

continue
else:
logger.info('Click no default invite')
Expand Down
Loading